Fix orderByDescending behaviour
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griffri
changed the title
orderByDescending behaviour
griffri
force-pushed
the
fix/orderByDescending
branch
from
45ce8d5
to
a804b16
Compare
griffri
force-pushed
the
fix/orderByDescending
branch
from
a804b16
to
2834a83
Compare
…rderByDescending to expect different items depending on alphabetical order
JackLewis-digirati
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where storage collection queries specifying
orderByDescending={field_name}would only order items by the creation date, regardless of which field was specified.It also updates the valid 'orderByDescending' test in
GetCollectionTeststo expect a different item when dealing with theslugandidfields, as they are now sorted alphabetically.